Skip to content
This repository was archived by the owner on Sep 28, 2020. It is now read-only.

Fallback to os temp directory if findCacheDir fail #154

Merged
merged 3 commits into from
Feb 22, 2017

Conversation

viankakrisna
Copy link
Contributor

@viankakrisna viankakrisna commented Feb 17, 2017

From the find-cache-dir readme:

Finds the cache dir using the supplied options. The algorithm tries to find a package.json file, searching every parent directory of the cwd specified (or implied from other options). It returns a string containing the absolute path to the cache directory, or null if package.json was never found.

This is a fallback for null condition. Investigated after @gaearon comments on facebook/create-react-app#1578 (comment)

From the readme: `Finds the cache dir using the supplied options. The algorithm tries to find a package.json file, searching every parent directory of the cwd specified (or implied from other options). It returns a string containing the absolute path to the cache directory, or null if package.json was never found.` This is a fallback for null condition. Investigated after @gaearon comments on facebook/create-react-app#1578 (comment)
@MoOx
Copy link
Contributor

MoOx commented Feb 22, 2017

I am not sure to follow how a project cannot have a package.json...
But just in case...

@MoOx MoOx merged commit 4fbffa0 into webpack-contrib:master Feb 22, 2017
@MoOx
Copy link
Contributor

MoOx commented Feb 22, 2017

Released in 1.6.2

@viankakrisna
Copy link
Contributor Author

@MoOx Thank you!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants