refactor: improve naming of test fixtures

webpack-contrib · Mar 17, 2017 · 7ccfa43 · 7ccfa43
1 parent 01ab011
commit 7ccfa43
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 13 deletions.
diff --git a/test/fixtures/less/non-less-import.less → test/fixtures/less/import-non-less.less b/test/fixtures/less/non-less-import.less → test/fixtures/less/import-non-less.less
diff --git a/test/fixtures/less/imports-paths.less → test/fixtures/less/import-paths.less b/test/fixtures/less/imports-paths.less → test/fixtures/less/import-paths.less
diff --git a/test/fixtures/less/imports-url.less → test/fixtures/less/import-url.less b/test/fixtures/less/imports-url.less → test/fixtures/less/import-url.less
diff --git a/test/fixtures/less/imports-node.less → test/fixtures/less/import-webpack.less b/test/fixtures/less/imports-node.less → test/fixtures/less/import-webpack.less
diff --git a/test/fixtures/less/imports.less → test/fixtures/less/import.less b/test/fixtures/less/imports.less → test/fixtures/less/import.less
diff --git a/test/helpers/createSpec.js b/test/helpers/createSpec.js
@@ -10,7 +10,7 @@ const cssFixturesPath = path.resolve(fixturesPath, 'css');
 const matchWebpackImports = /(@import\s+(\([^)]+\))?\s*["'])~/g;
 const lessBin = require.resolve('.bin/lessc');
 const ignore = [
-  'non-less-import',
+  'import-non-less',
   'error-import-not-existing',
   'error-mixed-resolvers',
 ];
@@ -23,8 +23,8 @@ const ignore = [
  * The object keys are the test ids.
  */
 const tildeReplacements = {
-  imports: '../node_modules/',
-  'imports-node': '../node_modules/',
+  import: '../node_modules/',
+  'import-webpack': '../node_modules/',
   'source-map': '../node_modules/',
 };
 // Maps test ids on cli arguments
@@ -34,7 +34,7 @@ const lessOptions = {
     `--source-map-basepath=${projectPath}`,
     `--source-map-rootpath=${projectPath}`,
   ],
-  'imports-paths': [
+  'import-paths': [
     `--include-path=${path.resolve(fixturesPath, 'node_modules')}`,
   ],
 };

diff --git a/test/index.test.js b/test/index.test.js
@@ -24,36 +24,36 @@ test('should compile simple less without errors', async () => {
 });
 
 test('should resolve all imports', async () => {
-  await compileAndCompare('imports');
+  await compileAndCompare('import');
 });
 
-test('should resolve all imports from node_modules', async () => {
-  await compileAndCompare('imports-node');
+test('should resolve all imports from node_modules using webpack\'s resolver', async () => {
+  await compileAndCompare('import-webpack');
 });
 
-test('should resolve imports from given paths', async () => {
-  await compileAndCompare('imports-paths', { paths: [__dirname, nodeModulesPath] });
+test('should resolve all imports from the given paths using Less\' resolver', async () => {
+  await compileAndCompare('import-paths', { paths: [__dirname, nodeModulesPath] });
 });
 
 test('should allow to disable webpack\'s resolver by passing an empty paths array', async () => {
-  const err = await compile('imports-node', moduleRules.basic({ paths: [] }))
+  const err = await compile('import-webpack', moduleRules.basic({ paths: [] }))
     .catch(e => e);
 
   expect(err).toBeInstanceOf(Error);
   expect(err.message).toMatch(/'~some\/css\.css' wasn't found/);
 });
 
 test('should not try to resolve import urls', async () => {
-  await compileAndCompare('imports-url');
+  await compileAndCompare('import-url');
 });
 
-test('should allow non-less-import', async () => {
+test('should allow to import non-less files', async () => {
   let inspect;
   const rules = moduleRules.nonLessImport((i) => {
     inspect = i;
   });
 
-  await compile('non-less-import', rules);
+  await compile('import-non-less', rules);
 
   const [css] = inspect.arguments;