Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: do not pass meta from other loaders #457

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

It is may create situation with false positive caching

Breaking Changes

Potential yes, but it is bug fix

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #457 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   96.50%   96.49%   -0.02%     
==========================================
  Files           5        5              
  Lines         229      228       -1     
  Branches       62       61       -1     
==========================================
- Hits          221      220       -1     
  Misses          8        8              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a16a0...8e95ad3. Read the comment docs.

@alexander-akait alexander-akait merged commit ba88040 into master Sep 4, 2020
@alexander-akait alexander-akait deleted the refactor-meta branch September 4, 2020 18:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant