Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support HTTP/2 #322

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Support HTTP/2 #322

merged 1 commit into from
Jul 13, 2018

Conversation

cainrus
Copy link
Contributor

@cainrus cainrus commented Jul 11, 2018

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

webpack-hot-middleware must to support HTTP/2 out of the box.

Breaking Changes

Nope.

Additional Info

It's impossible to cover with tests HTTP/2 mode right now because Express HTTP/2 support is in progress: expressjs/express#3390

@jsf-clabot
Copy link

jsf-clabot commented Jul 11, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #322 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage    87.5%   87.71%   +0.21%     
==========================================
  Files           3        3              
  Lines         232      236       +4     
  Branches       65       66       +1     
==========================================
+ Hits          203      207       +4     
  Misses         29       29
Impacted Files Coverage Δ
middleware.js 92.95% <100%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d46df6...22e922b. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants