Skip to content

Conversation

peter-spireng
Copy link
Contributor

At first moment we need agree on API and stringfy result. So, can you please review tests and if they are right, I can add real implementation.

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.17%. Comparing base (9fe2381) to head (b140c4e).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   76.66%   77.17%   +0.50%     
==========================================
  Files          10       11       +1     
  Lines         360      368       +8     
  Branches      112      114       +2     
==========================================
+ Hits          276      284       +8     
  Misses         73       73              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it here, you can implement this on loader side

@peter-spireng
Copy link
Contributor Author

Issue #95 is still open with "Help wanted" label, so I thought it is still valid feature request ...

@alexander-akait
Copy link
Member

We should avoid adding new methods here, if we really need it, we should implement it on webpack side (but I don't think we really need it). We want to deprecated it on the next major release.

And yes, we need to close issues...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants