-
-
Notifications
You must be signed in to change notification settings - Fork 39
fix: typescript definition #73
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 5 5
Lines 568 568
Branches 255 255
=======================================
Hits 560 560
Misses 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @vankop Can you look?
Oh, it is only for |
this is great approach, but as @evilebottnawi said already it is for future typescript release |
Yes, |
declaration now works with JS files 🤩 PR to core webpack confirmed =) |
/cc @yenshih can you put this using JSDoc? Now we generate declarations from JSDoc, anyway thanks for the PR |
It's fine :) |
It works same way as in ts files |
@vankop can you take care? |
@evilebottnawi later, maybe on the weekend |
This PR contains a:
Motivation / Use-Case
Better TypeScript definition base on control flow analysis for assertions:
microsoft/TypeScript#32695
Breaking Changes
Additional Info