-
-
Notifications
You must be signed in to change notification settings - Fork 627
tests: loader's tests for errors and warnings #1736
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
deprecations from ts-loader? |
Yes, can we test on |
Yes, let comment |
068e143
to
8deec71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need improve test
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
cffbdb3
to
5e7db04
Compare
5e7db04
to
2d41848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope it was fixed after removing execa
still same 😞 |
@snitin315 We need to solve it before release, there are two possible problems:
|
/cc @snitin315 Can we focus on it, because it is high priority for new release, we don't want break linter-loaders and other stuff what potential change exit code |
Yes, I'm looking into it. |
2d41848
to
8611c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should refactor https://github.com/webpack/webpack-cli/blob/next/packages/webpack-cli/lib/utils/Compiler.js 😞 It is "kitchen sink"
33097e1
to
4e1b4c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note
4e1b4c9
to
0f8bd8b
Compare
/cc @webpack/cli-team we need fix it before release |
What kind of change does this PR introduce?
test
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1581
Does this PR introduce a breaking change?
No
Other information