-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: resolve dev server hot options correctly #2022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add simple test for webpack serve --hot
and webpack serve --hot=only
to avoid problems in future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion. Rest looks good to me 😃
We already have tests for hot and no-hot flags, also updated the tests for createConfig which was causing this problem, adding for hot-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a rebase
/cc @anshumanv can you rebase, I think we should do release today |
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
rebase done |
Codecov Report
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
+ Coverage 68.99% 69.05% +0.06%
==========================================
Files 85 85
Lines 2422 2443 +21
Branches 489 492 +3
==========================================
+ Hits 1671 1687 +16
- Misses 751 756 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
Will be great to add more tests, but let's focus on coverage in other PRs
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Need update
Summary
hot
flag is resolved in serve packageDoes this PR introduce a breaking change?
No
Other information
Fixes #2004