Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(regression): handle key, cert, cacert and pfx in CLI #1688

Merged

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

fixes #1675 fixes #1686

Breaking Changes

No

Additional Info

Regresson

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #1688 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1688      +/-   ##
==========================================
+ Coverage   84.14%   84.39%   +0.24%     
==========================================
  Files           7        7              
  Lines         511      519       +8     
  Branches      155      159       +4     
==========================================
+ Hits          430      438       +8     
  Misses         64       64              
  Partials       17       17
Impacted Files Coverage Δ
lib/utils/createConfig.js 95.5% <100%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21687c3...a4d3d76. Read the comment docs.

@alexander-akait alexander-akait merged commit 4b2076c into master Feb 25, 2019
@alexander-akait alexander-akait deleted the fix-regression-handle-key-cert-ca-pfx-as-CLI-arguments branch February 25, 2019 10:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3.2.0 Breaks host parameter passed with options falling back to localhost
2 participants