-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixed issue when certificates are not imported on runtime #1686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
========================================
- Coverage 79.59% 79.2% -0.4%
========================================
Files 7 7
Lines 544 553 +9
Branches 165 169 +4
========================================
+ Hits 433 438 +5
- Misses 84 88 +4
Partials 27 27
Continue to review full report at Codecov.
|
Hi can we merge this ASAP @evilebottnawi @hiroppy 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this issue. LGTM
Sorry but I don't have webpack-dev-server's read-write
right of npm so we wait for @evilebottnawi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need tests, also please avoid fs.readFileSync
and path.resolve
, we already do this in Server
WIP on this |
Added back argument parser for certificates which resolves issue with custom domain.
Fixes #1675