Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed issue when certificates are not imported on runtime #1686

Closed
wants to merge 1 commit into from
Closed

Fixed issue when certificates are not imported on runtime #1686

wants to merge 1 commit into from

Conversation

shobhitsharma
Copy link

Added back argument parser for certificates which resolves issue with custom domain.

Fixes #1675

@jsf-clabot
Copy link

jsf-clabot commented Feb 23, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #1686 into master will decrease coverage by 0.39%.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1686     +/-   ##
========================================
- Coverage   79.59%   79.2%   -0.4%     
========================================
  Files           7       7             
  Lines         544     553      +9     
  Branches      165     169      +4     
========================================
+ Hits          433     438      +5     
- Misses         84      88      +4     
  Partials       27      27
Impacted Files Coverage Δ
lib/utils/createConfig.js 91.11% <55.55%> (-3.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884fac0...1ea3fae. Read the comment docs.

@phil-lgr
Copy link

Hi can we merge this ASAP @evilebottnawi @hiroppy 🙏

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this issue. LGTM

Sorry but I don't have webpack-dev-server's read-write right of npm so we wait for @evilebottnawi

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tests, also please avoid fs.readFileSync and path.resolve, we already do this in Server

@alexander-akait
Copy link
Member

WIP on this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3.2.0 Breaks host parameter passed with options falling back to localhost
5 participants