fix(package): update sockjs-client v1.1.5...1.3.0 (url-parse vulnerability)
#1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarbbottam
requested review from
alexander-akait and
michael-ciniawsky
as code owners
|
|
michael-ciniawsky
changed the title
sockjs-client v1.1.5...1.3.0 (url-parse vulnerability)
Codecov Report
@@ Coverage Diff @@
## master #1537 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 10 10
Lines 666 666
=======================================
Hits 493 493
Misses 173 173Continue to review full report at Codecov.
|
|
Released in |
This was referenced Oct 23, 2018
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A - the bug is not in webpack-dev-server but a dependency.
Motivation / Use-Case
Incorrect parsing in url-parse <1.4.3 returns wrong hostname which leads to multiple vulnerabilities such as SSRF, Open Redirect, Bypass Authentication Protocol.
Please refer https://nvd.nist.gov/vuln/detail/CVE-2018-3774 for further details.
Breaking Changes
NA
Additional Info
NA