ci(travis): Node 11 (on OS X) crashes, use 10 for now #1588
Conversation
odinho
requested review from
alexander-akait and
michael-ciniawsky
as code owners
|
If it is successful, I can add a comment with a link to this, so it's easy to remember removing it. |
| @@ -18,7 +18,7 @@ jobs: | |||
| stage: Test (MacOS) | |||
| os: 'osx' | |||
| env: SCRIPT=test | |||
| node_js: 'stable' | |||
| node_js: 10 | |||
There was a problem hiding this comment.
Let's add comment here on issue 👍
There was a problem hiding this comment.
Yeah, it was a good idea I saw it a bit late :) But I also don't have the URL before actually creating the PR, so :D Will update once the test-run is done.
|
Very interesting. It hung itself right before the test that segfaults on |
odinho
force-pushed
the
odinho/use_node_10_on_osx
branch
from
ccee61c to
209cd62
Compare
Codecov Report
@@ Coverage Diff @@
## master #1588 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 10 10
Lines 670 670
=======================================
Hits 496 496
Misses 174 174Continue to review full report at Codecov.
|
|
Looks tests passed |
|
Yes, but the first try did fail (before the comment added). So there is a chance that this will be flaky. It went from 100% fail, to something less than that, hopefully a very low fail-%, but we only have two data points. :) |
|
@odinho hm, maybe random failure, sometimes it is happens, let's merge this PR as is, if problem appear again we investigate deeply, big thanks! @odinho Just question: do you want join to |
Great, let's see :)
I can't take that on I'm afraid. I'm amazed at all the work you guys are doing, and you being lone maintainer for this one is quite impressive and sad. I will have a look at some of the other PRs next week and see why they are stalled and if there's some ways I can help without being a member. :) |
|
@odinho thanks, just help with issues and PRs (answer, review, mark as duplicate/invalid and etc). Any help welcome 👍 |
For Bugs and Features; did you add new tests?
No, this is about the tests.
Motivation / Use-Case
Mac OS X (on Travis) has a unknown segfault running the tests. About a month ago the
node/stablewent from Node 10 to Node 11, and then the project started getting these segfaults on Proxy tests as far as I can see.Additional Info
This is just a workaround, but the tests failing like now isn't very useful. I've added a bug with Node:
nodejs/node#24835
This change should be reverted once it is fixed.