-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(config): enable --overlay
#1968
Conversation
Is it regression? |
Yes. We were not aware of this bug. FYI: https://github.com/webpack/webpack-dev-server/tree/master/examples/cli/overlay |
Feel free to merge after CI green |
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 92.55% 92.47% -0.08%
==========================================
Files 28 28
Lines 1075 1077 +2
Branches 321 322 +1
==========================================
+ Hits 995 996 +1
- Misses 76 77 +1
Partials 4 4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 92.55% 92.47% -0.08%
==========================================
Files 28 28
Lines 1075 1077 +2
Branches 321 322 +1
==========================================
+ Hits 995 996 +1
- Misses 76 77 +1
Partials 4 4
Continue to review full report at Codecov.
|
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
Currently,
--overlay
is not working at master branch. Please try to runexamples/cli/overlay
.Breaking Changes
no
Additional Info