Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: allow Boolean type for --firewall #3041

Merged
merged 2 commits into from
Feb 24, 2021
Merged

feat: allow Boolean type for --firewall #3041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d50668
feat: add --no-firewall
snitin315 Feb 22, 2021
477f993
docs: update
snitin315 Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ Options:
--history-api-fallback Fallback to /index.html for Single Page Applications.
--compress Enable gzip compression.
--public <value> The public hostname/ip address of the server.
--firewall <value...> Enable/disable firewall, or set hosts that are allowed to access the dev server.
--firewall [value...] Enable firewall or set hosts that are allowed to access the dev server.
--no-firewall Disable firewall.

Global options:
--color Enable colors on console.
Expand Down
6 changes: 4 additions & 2 deletions bin/cli-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,12 @@ module.exports = {
},
{
name: 'firewall',
type: String,
type: [String, Boolean],
description:
'Enable/disable firewall, or set hosts that are allowed to access the dev server.',
'Enable firewall or set hosts that are allowed to access the dev server.',
negatedDescription: 'Disable firewall.',
multiple: true,
negative: true,
},
],
};