-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: convert dev server to webpack plugin #3850
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3850 +/- ##
==========================================
- Coverage 92.87% 92.75% -0.13%
==========================================
Files 14 14
Lines 1334 1338 +4
Branches 467 468 +1
==========================================
+ Hits 1239 1241 +2
- Misses 87 89 +2
Partials 8 8
Continue to review full report at Codecov.
|
@alexander-akait let me know if there any custom hooks required to be implemented here. |
|
||
let started = false; | ||
|
||
compiler.hooks.watchRun.tapPromise(pluginName, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should enable watch
before taping into watchRun
hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, plugin should work only for webpack watch
/webpack serve
, but I am afraid it is so late to override fs, need think more about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @alexander-akait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, in my roadmap on the next week
For Bugs and Features; did you add new tests?
WIP
Motivation / Use-Case
Dev Server should be a plugin
Breaking Changes
Nope
Additional Info
N/A