Update webpack-dev-server to accept a promise #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sokra If i branch off the latest 1.x version, and make the change there, would it be possible to get a patch version released? Not sure of the timeline when 2.0 will be released, and would like make this fix available. |
|
Thanks |
|
@crohde7707 & @sokra: |
mathieumg
added a commit
to mathieumg/webpack-dev-server
that referenced
this pull request
Nov 16, 2016
2 tasks
SpaceK33z
pushed a commit
that referenced
this pull request
Jan 31, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is associated with issue #417.
Webpack allows for a Promise instead of a config object, and this logic was missing from webpack-dev-server. This pull adds that same logic