feat: Optimize live bindings in export declarations (#18494) #19221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optimized live bindings processing to reduce overhead. - Ensured correct hook calls and traversal logic. Fixes webpack#18494
TheLarkInn
reviewed
Feb 12, 2025
| ); | ||
| } | ||
| break; | ||
|
|
There was a problem hiding this comment.
Do you have perf numbers on this optimization?. I'm not aware that moving this from a switch makes a performance difference.
Could you please provide a cpuprofile where you identified the need for the change (in all)
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
@bworline do you want to check over this also? |
|
@Vansh5632 please review the test failures and snapshot failures. |
alexander-akait
requested changes
Feb 13, 2025
before optimization: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized live bindings processing to reduce overhead
Fixes #18494
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?