-
Notifications
You must be signed in to change notification settings - Fork 3
Add Firefox support #1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
Firefox includes ssrcs in its sdp, but will misbehave if three m-sections include the same six ssrcs (3 media, 3 rtx) and 3 ssrc-groups.
This bypasses an issue where Firefox would block RTX packets because they don't carry the mid header extension, while media packets do (translated from rid).
This comes from Orphis/webrtc-sandbox#19. |
Replacing all this stringsoup by https://github.com/fippo/simulcast-playground/blob/gh-pages/split-merge.js (which has worked with Firefox for years) would be better |
Ping @alvestrand |
This is phrased as getting Firefox working, but all looks like improvements that are to spec to me (e.g. avoiding unnecessary |
@jan-ivar according to some theories the spec forbids a=ssrc lines with simulcast. I am not a fan of that theory and could not even find spec language but Firefox including both mid/rid and ssrc is overspecifying things. Your tone is not helping. |
This is moving from mid/rid towards ssrc which IIUC is not what the spec (for better or worse) desires? It turns out this shows what I believed to be a very interesting stats bug:
but
shows the same numbers so it can not be a stats bug. track.getSettings returns |
We could also remove the ssrc lines but would then lose the rtx mapping, so should remove rtx as well. |
See individual commits for more detailed comments.