Skip to content

Detect browser without relying on vendor prefixes #1160

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jan-ivar
Copy link
Collaborator

Fixes #1156.

@fippo
Copy link
Member

fippo commented Feb 28, 2025

isn't waiting for https://bugzilla.mozilla.org/show_bug.cgi?id=1750143 easier?
That will not require a major version bump which traditionally takes years (see #1065)

@jan-ivar
Copy link
Collaborator Author

Merging this PR should have the same net effect (of making the check UA-string based).

It might also end up being faster given Mozilla's neutral position on UA client hints.

I should have done this a year ago when we discovered this, but we gotta plant the seed at some point.

@fippo fippo added the breaking change breaking change that requires a major version bump label Mar 1, 2025
@jan-ivar
Copy link
Collaborator Author

Firefox (Nightly) 138 now has media.navigator.mozgetusermedia.enabled pref in about:config that if you set it to false causes adapter to return "Not a supported browser.".

While most major video conferencing websites I've tested so far appear to work, we're in contact with one affected by this. They're applying a fix on their end, but getting this merged would probably help them and other consumers of adapter.

@fippo
Copy link
Member

fippo commented Mar 13, 2025

Just trying to get it into the same release as #1127

https://www.reddit.com/r/firefox/comments/1j8401w/another_media_service_fallen_f1tv_is_a_costly/?share_id=qEAEN4EyxZnU9fGVFNaDI&utm_content=2&utm_medium=android_app&utm_name=androidcss&utm_source=share&utm_term=1&rdt=56689 should have demonstrated that UA sniffing is far more costly to Firefox than helping do actual feature detection but...

@jan-ivar
Copy link
Collaborator Author

Thanks for the link. It's a good example of why we want to get rid of things like mozGetUserMedia.

Streamlining UA sniffing helps us respond quickly with out-of-band interventions or dot-releases, which might need to include overriding UA strings in cases where websites reactively blocked Firefox.

@kkkkkkh-dd

This comment was marked as off-topic.

@fippo
Copy link
Member

fippo commented Apr 18, 2025

rebase needed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking change breaking change that requires a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox will be identified as "Not a supported browser." if mozGetUserMedia is removed
3 participants