Remove RTCPeerConnection shims in FF44+ #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to https://github.com/webrtc/adapter/issues/151, though checking on mozGetUserMedia should still be valid for a good while. |
|
\o/ |
|
Yes, I had to change indentation for quite a few lines. Here's the same diff ignoring whitespace. |
|
LGTM (yes, changing whitespaces really screws up the diff ;)) |
KaptenJansson
added a commit
that referenced
this pull request
Jan 22, 2016
Remove RTCPeerConnection shims in FF44+
|
@KaptenJansson Can we push a new version of https://webrtc.github.io/adapter/adapter-latest.js ? Not sure how that's done. It's not been updated yet, so I get deprecation warnings with adapter in Firefox now. |
|
will do, sorry for missing it yet again. |
|
done! |
|
Thanks! works now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the "moz prefix" deprecation warnings with adapter.js in Firefox 44 (releasing Tuesday).