Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

s2Member-List Search To Include display_name #578

Closed
jaswrks opened this issue May 22, 2015 · 6 comments
Closed

s2Member-List Search To Include display_name #578

jaswrks opened this issue May 22, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@jaswrks
Copy link
Contributor

jaswrks commented May 22, 2015

It has come to my attention (referencing internal ticket: https://websharks.zendesk.com/agent/tickets/6422) that [s2Member-List /] is not searching the display_name column as expected. This is due to a call to array_intersect() in the WordPress core that removes display_name from the list inadvertently.

@jaswrks jaswrks added the bug label May 22, 2015
@jaswrks jaswrks self-assigned this May 22, 2015
@jaswrks jaswrks added this to the Next Release milestone May 22, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue May 22, 2015
@jaswrks
Copy link
Contributor Author

jaswrks commented May 22, 2015

Short-Term Patch

  • Download this updated file and upload it via FTP. Allowing it to override your existing copy of s2member-pro/includes/classes/member-list.inc.php

@jaswrks
Copy link
Contributor Author

jaswrks commented May 22, 2015

Next Release Changelog:

  • (s2Member Pro) [s2Member-List /] Bug: This release corrects an issue in the [s2Member-List /] shortcode that was preventing the display_name DB column from being searchable. This release also adds the display_name to the list of default search_columns="" that are considered by the [s2Member-List /] shortcode. Props to @patdumond for researching this. See this GitHub issue for further details.

@jaswrks
Copy link
Contributor Author

jaswrks commented May 22, 2015

Noting that this issue (#552) remains open.

@ambroseya
Copy link

This bug was referenced from an issue I had opened, but the short term patch above does not seem to be a valid link, I can't find a copy of that patch file anywhere, and the plugin hasn't been updated to reflect that patch yet.

@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 2, 2015

Looks like the token in that link expired. I just updated it, so it should be working now. Can you please try downloading the file again? Referencing: #578 (comment)

@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 23, 2015

The latest release of s2Member v150722+ closes this issue.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)

@wpsharks wpsharks locked and limited conversation to collaborators Jul 23, 2015
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants