Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature Requst: s2Member-list Search Needs to Search All s2Member Fields #596

Closed
patdumond opened this issue Jun 16, 2015 · 9 comments
Closed
Assignees

Comments

@patdumond
Copy link

Referencing: https://websharks.zendesk.com/agent/tickets/6742

Related Issue/Feature Request: #578

The s2Member-list search functionality searches any field in wp-users AND any custom registration/profile fields the user has created. It does not search the default fields created with s2Member. The user who sent in the referenced Zendesk ticket is particularly interested in s2member_subscr_id, but all fields linked to a subscriber should be searchable.

@jaswrks
Copy link
Contributor

jaswrks commented Jun 17, 2015

s2member_subscr_id, but all fields linked to a subscriber should be searchable.

Agree. cc @raamdev

This is actually a very powerful idea. Challenging, since the WP_User_Query() class does not support it, but in the last round of updates I actually started moving away from that class in many ways.

Anyway, to allow a search for things like s2member_subscr_id is to allow a search for any wp_usermeta column at the same time. I'd love to get that into the [s2Member-List /] shortcode!

@raamdev
Copy link
Contributor

raamdev commented Jun 17, 2015

Sounds like a nice enhancement!

Here are two code samples I found related to searching wp_usermeta that may be worth reviewing when it comes time to work on this:

@raamdev
Copy link
Contributor

raamdev commented Dec 2, 2015

The following issues all appear to be duplicates of this issue, with a few slight variations in each one: #794 #334 #679 #555 #552 I recommend that we consolidate all of those into this (#596) issue.

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Dec 5, 2015
jaswrks pushed a commit that referenced this issue Dec 5, 2015
@jaswrks jaswrks mentioned this issue Dec 5, 2015
@jaswrks
Copy link
Contributor

jaswrks commented Dec 5, 2015

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Dec 5, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Dec 5, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Dec 5, 2015
@patdumond
Copy link
Author

@jaswsinc, @raamdev: This is a much better idea than all of the individual tickets. I "vote" for this feature. :)

@jaswrks
Copy link
Contributor

jaswrks commented Dec 5, 2015

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Dec 5, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Dec 5, 2015
@jaswrks
Copy link
Contributor

jaswrks commented Dec 5, 2015

Next Release Changelog:

  • (s2Member Pro) [s2Member-List /] Added the ability to search usermeta data too. For instance, you can now search first_name, last_name, nickname, description, s2member_subscr_id, s2member_custom, etc, etc. See this GitHub issue.

    Note: The first_name, last_name, and nickname columns are now a part of the default value for the search_columns="" attribute in the [s2Member-List /] shortcode. See also: this GitHub issue. Props @patdumond for her ideas.

  • (s2Member Pro) [s2Member-List /] There are some new orderby="" options. You may now choose to order the list by: first_name, last_name, or nickname.

  • (s2Member Pro) [s2Member-List /] It is now possible to search through s2Member Custom Registration/Profile Fields that may contain an array of values; i.e., you can now search any Custom Registration/Profile Field in s2Member. For instance, if a field is designed to accept multiple selections, or you provide a set of multiple checkbox options. See also: this GitHub issue.

  • (s2Member Pro) [s2Member-List /] Bug Fix: Meta fields that contained a timestamp were being displayed by the date_i18n() function in WP core. However, the time offset calculation was wrong; i.e., not a match to the local time configured by your installation of WordPress. Fixed in this release.

  • (s2Member Pro) [s2Member-List /] Bug Fix: Minor formatting corrections for replacement codes made available for the link_*="" attributes in the [s2Member-List /] shortcode.

  • (s2Member Pro) [s2Member-List /]: It is now possible to search for an exact match by surrounding your search query with double quotes; e.g., "john doe" (in quotes, for an exact match), instead of the default behavior, which is *john doe* behind-the-scenes; i.e., a fuzzy match.

  • (s2Member Pro) [s2Member-List /]: Several behind-the-scenes performance enhancements.

@jaswrks jaswrks closed this as completed Dec 5, 2015
@jaswrks jaswrks added this to the Next Release milestone Dec 5, 2015
@jaswrks jaswrks self-assigned this Dec 5, 2015
@jaswrks
Copy link
Contributor

jaswrks commented Dec 10, 2015

Work from this issue was released in s2Member & s2Member Pro v151210.
See changelog: http://s2member.com/changelog/

Future comments on this issue will now be blocked. If you have any trouble please open a new issue and report it. A big thanks to all of our great supporters. Happy Holidays :-) ❄️

@wpsharks wpsharks locked and limited conversation to collaborators Dec 10, 2015
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants