Stripe Image Branding Empty By Default

[jaswrks]

Referencing: wpsharks/s2member-kb#177 (comment)

We should update the s2Member software. By default, this configuration value should be empty--allowing your Stripe configuration to apply if not configured with s2Member.

[jaswrks]

Suggested Next Actions

• Empty the default value for this option here: https://github.com/websharks/s2member-pro/blob/150722/s2member-pro/includes/syscon.inc.php#L117
• Update the label to note that this field is optional: https://github.com/websharks/s2member-pro/blob/150722/s2member-pro/includes/menu-pages/stripe-ops.inc.php#L155
• Update the note underneath this field to explain what it defaults to whenever you leave it empty: https://github.com/websharks/s2member-pro/blob/150722/s2member-pro/includes/menu-pages/stripe-ops.inc.php#L164

[renzms]

Also reported here: https://websharks.zendesk.com/agent/tickets/8435

[jaswrks]

[jaswrks]

Next Release Changelog:

• (s2Member Pro) Stripe Bug Fix: This release improves the way Stripe Image Branding and Stripe Statement Descriptions are applied whenever you intentionally leave them empty. It also changes the default value of Stripe Image Branding to an empty string; which will tell Stripe to use the account-level default value that you configured in your Stripe Dashboard in favor of that which you configure with s2Member. The choice is still yours, but this release sets what others have told us are better default values. See also this GitHub issue if you'd like additional details.

[jaswrks]

Work from this issue was released in s2Member & s2Member Pro v151210.
See changelog: http://s2member.com/changelog/

Future comments on this issue will now be blocked. If you have any trouble please open a new issue and report it. A big thanks to all of our great supporters. Happy Holidays :-) ❄️