Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Other gateways list #715

Closed
clavaque opened this issue Sep 7, 2015 · 7 comments
Closed

Other gateways list #715

clavaque opened this issue Sep 7, 2015 · 7 comments
Assignees

Comments

@clavaque
Copy link
Contributor

clavaque commented Sep 7, 2015

This is a suggestion to improve the list of payment gateways.

2015-09-06_192921-other-gateways-order

Right now they don't seem to be in any particular order, so I suggest that they are either prioritized, or sorted alphabetically.

If prioritized, I'd move the default ones to the top, and the deprecated ones to the bottom.

I also suggest not having them in a scrollbox, so they're all visible when opening the admin page, instead of having some requiring to scroll in order to see them.

2015-09-06_195709-other-gateways-prioritized

@raamdev
Copy link
Contributor

raamdev commented Sep 8, 2015

👍

@jaswrks
Copy link
Contributor

jaswrks commented Sep 9, 2015

👍 Agree. Great point. TY!

@jaswrks
Copy link
Contributor

jaswrks commented Sep 22, 2015

Next Actions

  • New feature branch: feature/715 in the websharks/s2member-pro repo.

  • @clavaque suggested, and we agree...

    Right now they don't seem to be in any particular order, so I suggest that they are either prioritized, or sorted alphabetically. If prioritized, I'd move the default ones to the top, and the deprecated ones to the bottom.

    See this line of code and change the order of the array elements here. I suggest moving the default ones to the top, and the deprecated ones to the bottom as @clavaque suggested above. Feel free to break this long one-line list apart and put each array element on a line of it's own.

  • See this block of HTML markup. Remove the scrollbox div wrapper and test in a WordPress Dashboard. If any additional style tweaks are needed, feel free to make those. Or, you might find that the scrollbox div wrapper could stay, but just prevent it from scrolling by adding the overflow: visible; property to it's style="" attribute. Whatever is easier.

  • Submit PR.

@jaswrks
Copy link
Contributor

jaswrks commented Sep 22, 2015

Assigning this to @kristineds

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Sep 30, 2015
Sort order of payment gateway list and remove scrolling; See: wpsharks/s2member#715
@jaswrks
Copy link
Contributor

jaswrks commented Sep 30, 2015

Next Release Changelog:

  • (s2Member/s2Member Pro) Cleanup: This release improves the list of Other Gateways; moving deprecated payment gateways to the bottom of the list and improving the display of the list overall. Props @kristineds @clavaque. For further details, see this GitHub issue.

@jaswrks jaswrks closed this as completed Sep 30, 2015
@kristineds kristineds added this to the Next Release milestone Oct 8, 2015
@jaswrks
Copy link
Contributor

jaswrks commented Oct 9, 2015

2015-10-08_21-20-43

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Oct 9, 2015
@jaswrks
Copy link
Contributor

jaswrks commented Dec 10, 2015

Work from this issue was released in s2Member & s2Member Pro v151210.
See changelog: http://s2member.com/changelog/

Future comments on this issue will now be blocked. If you have any trouble please open a new issue and report it. A big thanks to all of our great supporters. Happy Holidays :-) ❄️

@wpsharks wpsharks locked and limited conversation to collaborators Dec 10, 2015
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

4 participants