Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show code and reason for non-1000 close events from server #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dstillman
Copy link

Currently, if the server closes the connection with an error code, the code and reason aren't shown in the console:

> foo
disconnected

This patch adds them to the "disconnected" line:

> foo
disconnected with error 4400: Error parsing JSON

@jnordberg
Copy link
Contributor

👍

1 similar comment
@oyvindwe
Copy link

+1

@nwwells
Copy link
Collaborator

nwwells commented Jan 24, 2017

This looks good. Can you resolve the conflicts and then I'll merge?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants