Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add maxPieceLength option #266

Closed
danilvalov opened this issue Jan 4, 2025 · 2 comments · Fixed by #267
Closed

Add maxPieceLength option #266

danilvalov opened this issue Jan 4, 2025 · 2 comments · Fixed by #267
Labels
released

Comments

@danilvalov
Copy link

What problem do you want to solve?
Many older torrent clients do not support piece length larger than a certain size (e.g. larger than 16MB).

What do you think is the correct solution to this problem?
It would be great to have an option to limit the maximum piece length.
SilentBot1 added a commit that referenced this issue Jan 4, 2025
@SilentBot1
feat: add maxPieceLength option to address #266
2bed028
@SilentBot1 SilentBot1 mentioned this issue Jan 4, 2025
Merged
@ThaUnknown
Copy link
Member

I ran into this a few years back, and it indeed is a problem, but I think the piece size should be hard capped at say 4MB, rather than introduce a new setting

SilentBot1 added a commit that referenced this issue Jan 4, 2025
@SilentBot1
feat: add maxPieceLength option (#267)
1264106 
* feat: add maxPieceLength option to address #266

* fix: update default maxPieceLength to be 4 MiB, rather than Infinity.
webtorrent-bot pushed a commit that referenced this issue Jan 4, 2025
@semantic-release-bot
chore(release): 6.1.0
dcfa9ba 
# [6.1.0](v6.0.18...v6.1.0) (2025-01-04)

### Features

* add maxPieceLength option ([#267](#267)) ([1264106](1264106)), closes [#266](#266)
@webtorrent-bot
Copy link

🎉 This issue has been resolved in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add maxPieceLength option webtorrent/create-torrent
3 participants
@danilvalov @ThaUnknown @webtorrent-bot