Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: Remove deprecated descr field #65

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Fix: Remove deprecated descr field #65

merged 14 commits into from
Dec 16, 2024

Conversation

Septias
Copy link
Contributor

@Septias Septias commented Dec 8, 2024 •
edited
Loading

Update webxdc types and remove usage of deprecated descr field

@Septias Septias changed the base branch from main to sk/add_nix December 8, 2024 18:04
@Septias Septias mentioned this pull request Dec 8, 2024
Closed
@Septias Septias requested review from adbenitez and faassen and removed request for adbenitez December 8, 2024 18:14
@Septias Septias marked this pull request as draft December 8, 2024 18:18
@Septias Septias marked this pull request as ready for review December 11, 2024 12:29
@adbenitez
Copy link
Contributor

adbenitez commented Dec 11, 2024 •
edited
Loading

wondering why CI didn't seem to have run for this PR, maybe this needs a rebase?

UPDATE: never mind, it is merging to another branch, why not to main?

@Septias
Copy link
Contributor Author

Septias commented Dec 11, 2024

I want to merge this into main directly after add_nix was merged

@Septias Septias mentioned this pull request Dec 12, 2024
Open
adbenitez
adbenitez approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm! npm run check fails locally, prettier needs to be applied and we should wait for CI to run and pass

@Septias Septias changed the base branch from sk/add_nix to main December 16, 2024 15:22
@Septias Septias merged commit dea6ad0 into main Dec 16, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adbenitez adbenitez adbenitez approved these changes

@faassen faassen Awaiting requested review from faassen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Septias @adbenitez