Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BREAKING CHANGE: puppet.id will change to puppet.loggedInUserId #160

Open
huan opened this issue Oct 15, 2021 · 2 comments
Open

BREAKING CHANGE: puppet.id will change to puppet.loggedInUserId #160

huan opened this issue Oct 15, 2021 · 2 comments
Labels
breaking change

Comments

@huan
Copy link
Member

huan commented Oct 15, 2021 •
edited
Loading

Before

  1. puppet.id is defined as undefined | string and will be set when the puppet logged in with a user-id

After

  1. puppet.id will store a UUID when instantiating the Puppet, and the log on/off status will use puppet.loggedInUserId instead.
  2. currentUserId will be defined as the undefined | string to store the logged in user id
@huan huan mentioned this issue Oct 15, 2021
Merged
@huan huan mentioned this issue Oct 17, 2021
Open
13 tasks
@padlocal
Copy link
Contributor

Lot of tests failed in PadLocal. Figured out what happened finally ...

padlocal added a commit to wechaty/puppet-padlocal that referenced this issue Apr 30, 2022
@padlocal
Adapt to Wechaty puppet API V1.x.
9e2ce61 
wechaty/puppet#160
@huan
Copy link
Member Author

huan commented Apr 30, 2022

Glad to know that Padlocal is moving on!

We have lots of improvements & enhancements on v1.x, with ... some breaking changes for good.

Please feel free to let me know whenever you have any questions about the v1.x!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huan @padlocal