v0.8.3 bug fix: ping endpoint #59

AIAmber · 2021-08-03T02:49:48Z

v0.8.3 bug fix: ping endpoint

1.get host from endpoint
2.ping host
3.pylint

1.get host from endpoint 2.ping host

v0.8.3 bug fix: ping endpoint

1.get host from endpoint 2.ping host

pylint

wj-Mcat

Thanks for your great issue to solve ping problem with endpoint, Please refer to this issue: wechaty/python-wechaty#233

wj-Mcat · 2021-08-03T06:23:54Z

src/wechaty_puppet_service/puppet.py

@@ -898,7 +898,12 @@ def _init_puppet(self):
            log.debug('get puppet ip address : <%s>', data)
            self.options.end_point = '{ip}:{port}'.format(**data)

-        if ping(self.options.end_point) is False:
+        if ':' not in self.options.end_point:


: is not required for the valid endpoint which can be the service name or url. Eg: wechaty-service in docker network or http://api.wechaty-service.com .

we can make a rule:

WECHATY_PUPPET_SERVICE_ENDPOINT must be written as {Host/Domain Name}:{port}

if use default port, we must write it. Eg: for http, we use 80, for https, we use 443

we must follow the identical rules when we write the WECHATY_PUPPET_SERVICE_ENDPOINT, otherwise there will be many cases that we can't deal with.

I believe there must be some bugs in ping code. but port is not required in ping function. Can you reproduce your problem? And can you fix it after add port support ?

Yes, you mean that it needs telnet.

socket is a good way, now i'm looking for the methods about socket

Great, looking forward for your latest commit. You can encapsulate it into utils.py module.

There are some developers waiting for this pr, please complete the development and testing of this feature as soon as possible. Many thanks for your sharing and understanding.

ok, i will make it soon

I did a simple local test, no problem. please review my code.

1.ping port 2.if not port, ping host

v0.8.3 bug fix2: test endpoint

wj-Mcat

Please fix linting to keep the code quality. Thanks please.

wj-Mcat · 2021-08-04T02:56:26Z

src/wechaty_puppet_service/utils.py

+def test_endpoint(end_point: str) -> float:
+    """
+        test_endpoint:
+        1.If there is port: telnet
+        2.If there is host/domain: ping or
+    """
+    tn = Telnet()
+    host, port = extract_host_and_port(end_point)
+    if port is None:
+        return ping(host)
+    else:
+        try:
+            tn.open(host, port=port)
+        except Exception:
+            return False
+    return True


Your return data type is Wrong:
You define the return type is float, but you return float/bool data type. This code will not pass CI testing.

no, there are 2 pylint errors:
1./puppet.py:37:0: W0611: Unused ping imported from ping3 (unused-import)
2./utils.py:55:4: R1705: Unnecessary "else" after "return" (no-else-return)

i just fix these pylint errors, let it run CI test.

1.pylint bug fix

pylint bug fix

AIAmber

1

AIAmber · 2021-08-04T03:11:28Z

Please fix linting to keep the code quality. Thanks please.

1

wj-Mcat · 2021-08-04T03:17:14Z

Please fix linting to keep the code quality. Thanks please.

1

??? Your CI testing is down.

AIAmber · 2021-08-04T03:19:20Z

Please fix linting to keep the code quality. Thanks please.

1

??? Your CI testing is down.

oh no, there are 2 other pylint errors:
1./utils.py:63:15: W0703: Catching too general exception Exception (broad-except)
2./utils.py:25:0: C0411: standard import "from telnetlib import Telnet" should be placed before "from wechaty_puppet.exceptions import WechatyPuppetConfigurationError" (wrong-import-order)

wj-Mcat · 2021-08-04T03:20:44Z

Please fix linting to keep the code quality. Thanks please.

1

??? Your CI testing is down.

oh no, there are 2 other pylint errors:
1./utils.py:63:15: W0703: Catching too general exception Exception (broad-except)
2./utils.py:25:0: C0411: standard import "from telnetlib import Telnet" should be placed before "from wechaty_puppet.exceptions import WechatyPuppetConfigurationError" (wrong-import-order)

This is the general linting error, I believe you can fix it. Go ahead.

1.pylint bug fix2

pylint fix2

AIAmber · 2021-08-04T03:28:26Z

Please fix linting to keep the code quality. Thanks please.

1

??? Your CI testing is down.

oh no, there are 2 other pylint errors:
1./utils.py:63:15: W0703: Catching too general exception Exception (broad-except)
2./utils.py:25:0: C0411: standard import "from telnetlib import Telnet" should be placed before "from wechaty_puppet.exceptions import WechatyPuppetConfigurationError" (wrong-import-order)

This is the general linting error, I believe you can fix it. Go ahead.

Yes, I will try again.

AIAmber · 2021-08-04T03:39:38Z

Please fix linting to keep the code quality. Thanks please.

1

??? Your CI testing is down.

oh no, there are 2 other pylint errors:
1./utils.py:63:15: W0703: Catching too general exception Exception (broad-except)
2./utils.py:25:0: C0411: standard import "from telnetlib import Telnet" should be placed before "from wechaty_puppet.exceptions import WechatyPuppetConfigurationError" (wrong-import-order)

This is the general linting error, I believe you can fix it. Go ahead.

Yes, I will try again.
Could you recommend a good pylint tool for me to do some local testing?

1.pylint bug fix3

pylint3

AIAmber · 2021-08-04T04:06:03Z

i try it again, then i will install pylint and do some local testing.

i'm sorry to have incommoded you for my pylint

1.ping type ignore

AIAmber · 2021-08-04T04:35:59Z

yes, pylint passed!

i add ping # type ignore, please approve it again

ping type ignore

wj-Mcat · 2021-08-04T07:38:14Z

Awesome, the last step: bump the version in VERSION file to trigger the CD stage.

v0.8.4 version

wj-Mcat

LGTM

wj-Mcat · 2021-08-04T07:49:13Z

Link to wechaty/PMC#16

AIAmber · 2021-08-04T07:51:45Z

Link to wechaty/PMC#16

yeah, i make it done.

last,
i got a lot about this project, and THANK YOU a lot.

wj-Mcat · 2021-08-04T07:54:42Z

If you wish, you can continue to participate in the python-wechaty project development, issue processing and documentation improvements. Welcome to become contrbutor of python-wechaty 🎉 🎉 🎉

AIAmber · 2021-08-04T07:56:51Z

Yes, I think I will do it better

huan · 2021-08-04T08:52:21Z

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited AIAmber to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

AIAmber added 4 commits August 3, 2021 10:39

v0.8.3 bug fix: ping endpoint

2a89ba6

1.get host from endpoint 2.ping host

Merge pull request #1 from AIAmber/leo_win

31c50c3

v0.8.3 bug fix: ping endpoint

v0.8.3 bug fix: ping endpoint

600bef7

1.get host from endpoint 2.ping host

Merge pull request #2 from AIAmber/leo_win

751f8f2

pylint

AIAmber requested a review from a team as a code owner August 3, 2021 02:49

wj-Mcat requested changes Aug 3, 2021

View reviewed changes

AIAmber added 2 commits August 4, 2021 10:48

v0.8.3 bug fix2: test endpoint

66cfca4

1.ping port 2.if not port, ping host

Merge pull request #3 from AIAmber/leo_win

0c167c4

v0.8.3 bug fix2: test endpoint

wj-Mcat requested changes Aug 4, 2021

View reviewed changes

AIAmber added 2 commits August 4, 2021 11:03

v0.8.3 bug fix3: test endpoint. pylint bug fix

69e999f

1.pylint bug fix

Merge pull request #4

300a924

pylint bug fix

AIAmber commented Aug 4, 2021

View reviewed changes

AIAmber requested a review from wj-Mcat August 4, 2021 03:10

AIAmber added 2 commits August 4, 2021 11:26

v0.8.3 bug fix4: test endpoint. pylint bug fix2

61e7cd7

1.pylint bug fix2

Merge pull request #5

073cd56

pylint fix2

AIAmber added 2 commits August 4, 2021 11:56

v0.8.3 bug fix4: test endpoint. pylint bug fix3

66ab59d

1.pylint bug fix3

Merge pull request #6

13759af

pylint3

v0.8.3 bug fix5: ping type ignore

f9dba32

1.ping type ignore

Merge pull request #7

c6fd0a5

ping type ignore

AIAmber added 2 commits August 4, 2021 15:42

v0.8.4 version

d201abc

Merge pull request #8 from AIAmber/leo_win

1929089

v0.8.4 version

wj-Mcat approved these changes Aug 4, 2021

View reviewed changes

wj-Mcat merged commit d1c0c38 into wechaty:master Aug 4, 2021

This was referenced Aug 4, 2021

add log error for ping exception #61

Merged

Using ping will cause to raise an exception, but message missing #60

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v0.8.3 bug fix: ping endpoint #59

v0.8.3 bug fix: ping endpoint #59

AIAmber commented Aug 3, 2021

wj-Mcat left a comment

wj-Mcat Aug 3, 2021

AIAmber Aug 3, 2021

AIAmber Aug 3, 2021 •

edited

Loading

AIAmber Aug 3, 2021

wj-Mcat Aug 3, 2021

AIAmber Aug 3, 2021

wj-Mcat Aug 3, 2021

wj-Mcat Aug 4, 2021

AIAmber Aug 4, 2021

AIAmber Aug 4, 2021

wj-Mcat left a comment

wj-Mcat Aug 4, 2021

AIAmber Aug 4, 2021

AIAmber Aug 4, 2021

AIAmber left a comment

AIAmber commented Aug 4, 2021

wj-Mcat commented Aug 4, 2021 •

edited

Loading

AIAmber commented Aug 4, 2021

wj-Mcat commented Aug 4, 2021

AIAmber commented Aug 4, 2021

AIAmber commented Aug 4, 2021

AIAmber commented Aug 4, 2021

AIAmber commented Aug 4, 2021 •

edited

Loading

wj-Mcat commented Aug 4, 2021

wj-Mcat left a comment

wj-Mcat commented Aug 4, 2021

AIAmber commented Aug 4, 2021

wj-Mcat commented Aug 4, 2021

AIAmber commented Aug 4, 2021

huan commented Aug 4, 2021

v0.8.3 bug fix: ping endpoint #59

v0.8.3 bug fix: ping endpoint #59

Conversation

AIAmber commented Aug 3, 2021

wj-Mcat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AIAmber Aug 3, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wj-Mcat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AIAmber left a comment

Choose a reason for hiding this comment

AIAmber commented Aug 4, 2021

wj-Mcat commented Aug 4, 2021 • edited Loading

AIAmber commented Aug 4, 2021

wj-Mcat commented Aug 4, 2021

AIAmber commented Aug 4, 2021

AIAmber commented Aug 4, 2021

AIAmber commented Aug 4, 2021

AIAmber commented Aug 4, 2021 • edited Loading

wj-Mcat commented Aug 4, 2021

wj-Mcat left a comment

Choose a reason for hiding this comment

wj-Mcat commented Aug 4, 2021

AIAmber commented Aug 4, 2021

wj-Mcat commented Aug 4, 2021

AIAmber commented Aug 4, 2021

huan commented Aug 4, 2021

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

2. Update Your Wechaty Contributor Profile

3. Join The Contributor Only WeChat Room

AIAmber Aug 3, 2021 •

edited

Loading

wj-Mcat commented Aug 4, 2021 •

edited

Loading

AIAmber commented Aug 4, 2021 •

edited

Loading