refactor registry for support setting service available #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdaxb
force-pushed
the
support_setting_service_avaiable
branch
from
380e949 to
946ee4d
Compare
| ConsulService service = buildService(url); | ||
| client.registerService(service); | ||
| heartbeatManager.addHeartbeatServcieId(service.getId()); | ||
| registeredUrls.putIfAbsent(url, client); | ||
| getRegisteredServiceUrls().add(url); |
There was a problem hiding this comment.
ConsulRegistry里的add和remove操作是不是和AbstractRegistry里的重复了
Open
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11