Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Arbitrary.WithExceptions: Too many open files #257

Closed
edsko opened this issue Nov 1, 2024 · 2 comments · Fixed by #259
Closed

Arbitrary.WithExceptions: Too many open files #257

edsko opened this issue Nov 1, 2024 · 2 comments · Fixed by #259
Labels
bug Something isn't working priority: high Usability of the library severely hindered testsuite Problem with the test suite but not the main library

Comments

@edsko
Copy link
Collaborator

edsko commented Nov 1, 2024

Example run:

$ cabal run test-grapesy -- -p Arbitrary.WithExceptions --quickcheck-tests=1000
grapesy
  Prop
    Test.Prop.Dialogue
      Arbitrary
        WithExceptions
          connPerRPC: FAIL (1.45s)
            *** Failed! Exception: 'Network.Socket.accept: resource exhausted (Too many open files)' (after 597 tests and 1 shrink):
            DialogueWithExceptions (UnnormalizedDialogue [])
            GlobalSteps {getGlobalSteps = []}
            Use --quickcheck-replay="(SMGen 2488985887102302335 10295797329131458171,96)" to reproduce.
            Use -p '/Arbitrary.WithExceptions/&&/connPerRPC/' to rerun this test only.
          sharedConn: FAIL
            *** Failed! Exception: 'Network.Socket.accept: resource exhausted (Too many open files)' (after 1 test and 1 shrink):
            DialogueWithExceptions (UnnormalizedDialogue [])
            GlobalSteps {getGlobalSteps = []}
            Use --quickcheck-replay="(SMGen 7677182066308157554 12389343332662471367,0)" to reproduce.
            Use -p '/Arbitrary.WithExceptions/&&/sharedConn/' to rerun this test only.

This happens only with the WithExceptions tests, not with the regular tests, and it also doesn't happen (at least, I haven''t seen it) when running fewer tests. I think this is a regression, didn't use to happen.

@edsko edsko added bug Something isn't working testsuite Problem with the test suite but not the main library priority: medium Should be done before the library can be considered complete labels Nov 1, 2024
@edsko
Copy link
Collaborator Author

edsko commented Nov 6, 2024

Moving this to high priority as it can affect non-test code also; file handles are scarce resources that we should be careful with. Not sure if this is a regression in grapesy itself or in a dependency.

@edsko edsko added priority: high Usability of the library severely hindered and removed priority: medium Should be done before the library can be considered complete labels Nov 6, 2024
@edsko
Copy link
Collaborator Author

edsko commented Nov 11, 2024

See kazu-yamamoto/http2#151 for an analysis of what is happening.

edsko added a commit that referenced this issue Nov 16, 2024
edsko added a commit that referenced this issue Nov 16, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Nov 19, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Nov 23, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Nov 23, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Nov 23, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Nov 23, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Nov 29, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Dec 4, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Dec 4, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Dec 17, 2024
The problem is fixed in latest `http2`
(`7036a3429fb08bfcd5947230c37d1f3e63dfb3a6`).  See
kazu-yamamoto/http2#151 for the `http2` bug report.

Closes #257.
edsko added a commit that referenced this issue Dec 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working priority: high Usability of the library severely hindered testsuite Problem with the test suite but not the main library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant