Add HsTypRef for handling TypElaborated #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
commented
Oct 29, 2024
| @@ -6,7 +6,9 @@ instance Storable CFoo | |||
| poke = \x_1 -> \x_2 -> case x_2 of | |||
| {MkCFoo cFoo_i_3 | |||
| cFoo_c_4 -> pokeByteOff x_1 0 cFoo_i_3 >> pokeByteOff x_1 32 cFoo_c_4}} | |||
| data CBar = MkCBar {cBar_foo1 :: Void, cBar_foo2 :: Void} | |||
| data CBar | |||
| = MkCBar {cBar_foo1 :: CStruct'0020foo, | |||
There was a problem hiding this comment.
TypElaborated and name manging is broken. The symbol in TypElaborated is struct foo, not bare foo; which gets manged to something different than a standalone foo in struct foo.
There was a problem hiding this comment.
Yes, that is little more than a stand-in at the moment. We need to do this properly.
There was a problem hiding this comment.
Have opened #244 to track this.
edsko
force-pushed
the
data-decl-cons-d
branch
from
b4c6893
to
54f3a84
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.