Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

internal/ethapi: changed 'blockNumber' data type (GetReceiptsByHash RPC) #52

Merged
merged 1 commit into from
May 19, 2023
Merged

internal/ethapi: changed 'blockNumber' data type (GetReceiptsByHash RPC) #52

merged 1 commit into from
May 19, 2023

Conversation

cp-jhjin
Copy link

internal/ethapi: changed 'blockNumber' data type from BigInt to hexUtil.Uint64 (GetReceiptsByHash RPC)

@ReleaseWemix ReleaseWemix requested a review from wm-jsong1230 May 19, 2023 01:23
@wm-jsong1230 wm-jsong1230 requested a review from cp-khs May 19, 2023 01:24
wm-jsong1230
wm-jsong1230 approved these changes May 19, 2023
View reviewed changes
Copy link

@wm-jsong1230 wm-jsong1230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for consistency

cp-khs
cp-khs approved these changes May 19, 2023
View reviewed changes
Copy link

@cp-khs cp-khs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cp-khs cp-khs merged commit 523c479 into wemixarchive:dev May 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cp-khs cp-khs cp-khs approved these changes

@wm-jsong1230 wm-jsong1230 wm-jsong1230 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cp-jhjin @cp-khs @wm-jsong1230