Fix/dockerfile #85
Merged
Fix/dockerfile #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docker-compose.yml were modified for testing. |
kai-yu-wm
approved these changes
May 24, 2024
This was referenced May 29, 2024
Merged
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Starting with Go 1.12, some functionality of the syscall package has been moved to the golang.org/x/sys/unix package and syscall package has been deprecated.
So syscall package was replaced to golang.org/x/sys/unix package
commit hash: 5028477
The Dockerfiles were modified to function correctly, and for testing purposes, you need to use the branch where the syscall package has been replaced to golang.org/x/sys/unix package, which is currently only fix/dockerfile. Therefore, when cloning the repository at line 30, you need to add the -b fix/dockerfile option to ensure it works.
commit hash: 18c3921
While converting the syscall package to the olang.org/x/sys/unix package, an issue arose in the exitStatus function used for existing tests. Casting ExitError.Sys() to unix.WaitStatus was not feasible, leading to errors in TestT8n in t8n_test.go. To resolve this, ExitError.Sys() was replaced to ExitError.ProcessState.ExitCode()
commit hash: 1067c61
Closes #83