Allowing config flag to turn off flask-compress (apache#4617)

wenchma · Mar 16, 2018 · 95c8a99 · 95c8a99
1 parent 6044ea4
commit 95c8a99
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/docs/installation.rst b/docs/installation.rst
@@ -173,6 +173,9 @@ work on Windows so the `superset runserver` command is not expected to work
 in that context. Also note that the development web
 server (`superset runserver -d`) is not intended for production use.
 
+If not using gunicorn, you may want to disable the use of flask-compress
+by setting `ENABLE_FLASK_COMPRESS = False` in your `superset_config.py`
+
 Flask-AppBuilder Permissions
 ----------------------------
 

diff --git a/superset/__init__.py b/superset/__init__.py
@@ -168,7 +168,8 @@ def index(self):
 ConnectorRegistry.register_sources(module_datasource_map)
 
 # Flask-Compress
-Compress(app)
+if conf.get('ENABLE_FLASK_COMPRESS'):
+    Compress(app)
 
 # Hook that provides administrators a handle on the Flask APP
 # after initialization

diff --git a/superset/config.py b/superset/config.py
@@ -405,6 +405,10 @@ class CeleryConfig(object):
 #        return "-- [SQL LAB] {username} {dttm}\n sql"(**locals())
 SQL_QUERY_MUTATOR = None
 
+# When not using gunicorn, (nginx for instance), you may want to disable
+# using flask-compress
+ENABLE_FLASK_COMPRESS = True
+
 try:
     if CONFIG_PATH_ENV_VAR in os.environ:
         # Explicitly import config module that is not in pythonpath; useful