[dataset] add shuffle at shards tar/raw file level #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
raw 和 shard的source dataset需要加个shuffle的参数，原来是不shuffle的，要不然ut 过不了 |
OK. |
增加了两个参数， |
|
默认值可以直接给个sys.max |
Mddct
approved these changes
Mar 20, 2024
Comment on lines
398
to
+402
| self.dp = TextLineDataPipe(filenames).repeat(cycle).prefetch( | ||
| prefetch).shard(partition) | ||
| prefetch) | ||
| if shuffle: | ||
| self.dp = self.dp.shuffle(buffer_size=shuffle_size) | ||
| self.dp = self.dp.shard(partition) |
There was a problem hiding this comment.
这个shuffle是不是应该在prefetch之前？@Mddct
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.