Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

core - angular : v17 #83

Merged
merged 2 commits into from
Nov 30, 2023
Merged

core - angular : v17 #83

merged 2 commits into from
Nov 30, 2023

Conversation

rbalet
Copy link
Contributor

@rbalet rbalet commented Nov 11, 2023

Core

  • Update to angular v17
  • Update the README
  • Change "@angular/core": ">=14.0.0 <17.0.0" into "@angular/core": ">=14.0.0",

Why >=14.0.0 ?

Because angular seems stable enough and having <17.0.0 make people not able to update their library, even if this is basically working.

@rbalet
Copy link
Contributor Author

rbalet commented Nov 13, 2023

@werthdavid Could you let me know when you'd have time to merge this pull request (if it looks ok for you?).

That I know if I shall wait a little bit or make a local reproduction for a short moment.

Cheers.

@rbalet rbalet mentioned this pull request Nov 30, 2023
@werthdavid
Copy link
Owner

Thanks again @rbalet !! Best man. Sorry for the delay, I was on my "parental vacation" where I didn't really have internet access. I'll take a look now. Much appreciated as always!

@werthdavid werthdavid merged commit 3f57b15 into werthdavid:master Nov 30, 2023
@rbalet
Copy link
Contributor Author

rbalet commented Nov 30, 2023

@werthdavid I weren't sure you saw it, therefore the issue, but sorry for being a bit insistant.

That was the last library that weren't accessible for v17 and I really wanted to try out the latest feature.

Thx again a wish you a lovely day

@werthdavid
Copy link
Owner

no worries, don't hesitate to mention me, usually I'm working with github on a daily basis

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants