Contributors: move to sites, change context of use #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pre-approved upon successful review. |
duboisp
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Todo:
- Centralize sample inside the contributor component.
- (Optional) remove the "gc-" prefix in the file/folder name for the contributor component
- Update the contributor component documentation to add more emphasis on the breaking change + migration instruction.
- Page details - move demoted pattern in demoted folder
- For "contributor" component, make it a minor version for now (v1.1) because both are still ok, but identify the version 1.0 as demoted. We will increase the major version when we will switch the v1.0 from "demoted" into "deprecated" state.
This change is:
- Minor change for contributor component - Add new pattern where located in the page details section
- Minor change for page details component - Add new pattern that include the contributor component
- Minor change for Topic template - Add new pattern that include the new page details with the contributor component
- Minor change for the "Topic" template - Add new pattern that implement page-details v 3.3 where the contributor component are in the page-details section
- We will perform a major change to those component, when we will switch them from "demoted" into "deprecated" at our next major release
Garneauma
force-pushed
the
gc-contributors
branch
from
381df46 to
84339ed
Compare
duboisp
requested changes
Feb 7, 2025
There was a problem hiding this comment.
I reviewed and tested locally all modified files. Its look good. There is a few inline comment to address and the following change to do:
Can you add a temporary redirect for the following files? This is to avoid broken link from the guidance material. Add a comment that those redirect can be removed in a year or two from now.
- /components/gc-contributors/gc-contributors-doc-en.html
- /components/gc-contributors/gc-contributors-doc-fr.html
- /components/gc-contributors/gc-contributors-en.html
- /components/gc-contributors/gc-contributors-fr.html
Once that completed, I will be able to approve this PR.
Note: This PR does impact:
- Minor - Contributor
- Minor - Page details
- Minor - Topic template
Garneauma
force-pushed
the
gc-contributors
branch
from
84339ed to
3b58812
Compare
Garneauma
had a problem deploying
to
github-ci
GitHub Actions
Failure
Garneauma
force-pushed
the
gc-contributors
branch
from
3b58812 to
d923cf8
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to WET-505