Skip to content

feat(4337): entrypoint 0.8 + eip7702 #3535

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 26 commits into from

Conversation

plusminushalf
Copy link
Contributor

This PR will add entrypoint 0.8 & EIP-7702 support for 4337 accounts.

Copy link

vercel bot commented Apr 1, 2025

@plusminushalf is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: 637adde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jxom jxom mentioned this pull request Apr 12, 2025
@@ -115,7 +115,7 @@ export async function toSmartAccount<
this.getFactoryArgs(),
implementation.signMessage(parameters),
])
if (factory && factoryData)
if (factory && factoryData && factory !== '0x7702')
Copy link
Member

@jxom jxom Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7702 accounts can still use ERC-6492, right?

Copy link
Contributor Author

@plusminushalf plusminushalf Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jxom If the account is in not deployed, ERC-6492 requires a valid factory and factory data. However, 7702 accounts don't use factories, instead require a valid authorisation that points EOA to a valid contract code for validation.

@@ -115,7 +115,7 @@ export async function toSmartAccount<
this.getFactoryArgs(),
implementation.signMessage(parameters),
])
if (factory && factoryData)
if (factory && factoryData && factory !== '0x7702')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (factory && factoryData && factory !== '0x7702')
if (factory && factoryData)

@@ -128,7 +128,7 @@ export async function toSmartAccount<
this.getFactoryArgs(),
implementation.signTypedData(parameters),
])
if (factory && factoryData)
if (factory && factoryData && factory !== '0x7702')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (factory && factoryData && factory !== '0x7702')
if (factory && factoryData)

@jxom jxom changed the title Add entrypoint 0.8 & 7702 support feat(4337): entrypoint 0.8 + eip7702 Apr 16, 2025
@jxom
Copy link
Member

jxom commented Apr 17, 2025

Moving to #3580 to unlock CI properly.

@jxom jxom closed this Apr 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants