-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(4337): entrypoint 0.8 + eip7702 #3535
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@plusminushalf is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
Add tests
d7c3aa9
to
c07fda0
Compare
@@ -115,7 +115,7 @@ export async function toSmartAccount< | |||
this.getFactoryArgs(), | |||
implementation.signMessage(parameters), | |||
]) | |||
if (factory && factoryData) | |||
if (factory && factoryData && factory !== '0x7702') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7702 accounts can still use ERC-6492, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jxom If the account is in not deployed, ERC-6492 requires a valid factory and factory data. However, 7702 accounts don't use factories, instead require a valid authorisation that points EOA to a valid contract code for validation.
@@ -115,7 +115,7 @@ export async function toSmartAccount< | |||
this.getFactoryArgs(), | |||
implementation.signMessage(parameters), | |||
]) | |||
if (factory && factoryData) | |||
if (factory && factoryData && factory !== '0x7702') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (factory && factoryData && factory !== '0x7702') | |
if (factory && factoryData) |
@@ -128,7 +128,7 @@ export async function toSmartAccount< | |||
this.getFactoryArgs(), | |||
implementation.signTypedData(parameters), | |||
]) | |||
if (factory && factoryData) | |||
if (factory && factoryData && factory !== '0x7702') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (factory && factoryData && factory !== '0x7702') | |
if (factory && factoryData) |
Moving to #3580 to unlock CI properly. |
This PR will add entrypoint 0.8 & EIP-7702 support for 4337 accounts.