Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

voterFacebookSaveToCurrentAccount needed for FacebookSignIn #42

Open
DaleMcGrew opened this issue Mar 2, 2021 · 2 comments
Open

voterFacebookSaveToCurrentAccount needed for FacebookSignIn #42

DaleMcGrew opened this issue Mar 2, 2021 · 2 comments

Comments

@DaleMcGrew
Copy link
Member

In testing the addition of Facebook # to Campaigns, I found one situation where it isn't working. When the email associated with Facebook is not in WeVoteServer database (Email or Voter email), the Facebook # fails. If you then # with email (using a verification code emailed to you), and sign out, Facebook # will work the second time (after the email address has been created in WeVoteServer).

To fix this, when you #, we need to support calling the API voterFacebookSaveToCurrentAccount (an alternate to voterMergeTwoAccountsByFacebookKey) in this file: Campaigns/src/js/components/Facebook/FacebookSignIn.jsx

I have pasted in the code (commented out) that was used in WebApp to call this API.

@SailingSteve
Copy link
Member

This is resolved by a prior PR

@SailingSteve
Copy link
Member

SailingSteve commented Sep 2, 2021

Dale McGrew 5:01 PM
Hi Steve, Facebook # works on my local machine on a Campaign URL, yay! It doesn’t seem to be bringing over any information from Facebook though (first/last name, photo, etc.)
I wonder if it is related to voterFacebookSaveToCurrentAccount and/or voterMergeTwoAccountsByFacebookKey mentioned in this: (issue 42)

SailingSteve added a commit to SailingSteve/Campaigns that referenced this issue Sep 2, 2021
Made sure VoterActions.voterFacebookSaveToCurrentAccount() was being
called when appropriate.
Verify that this solves wevote/issues/42
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants