Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolving \u{f115} on macos take ~0.5 seconds in the paint routine #508

Closed
wez opened this issue Mar 2, 2021 · 1 comment
Closed

Resolving \u{f115} on macos take ~0.5 seconds in the paint routine #508

wez opened this issue Mar 2, 2021 · 1 comment
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. macOS Issue applies to Apple macOS

Comments

@wez
Copy link
Owner

wez commented Mar 2, 2021

Can repro with wezterm -n and running print("\uf115") in the python3 repl.

May need to do something to perform the fallback font resolution via the font locator in a background thread, then invalidate the cached glyph and shape information when its done.

@wez wez added bug Something isn't working macOS Issue applies to Apple macOS labels Mar 2, 2021
wez added a commit that referenced this issue Mar 23, 2021
If shaping can't resolve some glyphs, queue the font locator
fallback resolution to another thread; meanwhile, a last resort
glyph is used.

That thread can trigger an invalidation once the fallback resolve
is complete, the window is invalidated and the last resort glyph
is replaced by the resolve glyph.

refs: #559
refs: #508
@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Mar 23, 2021
wez added a commit that referenced this issue Mar 23, 2021
@wez wez closed this as completed in eefdb66 Mar 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. macOS Issue applies to Apple macOS
Projects
None yet
Development

No branches or pull requests

1 participant