Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow passing arguments to git rebase #422

Merged

Conversation

carlfriedrich
Copy link
Collaborator

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

If non-option arguments are passed to git forgit rebase, pass them
through directly to git rebase, without launching the interactive
selector, just like we do for other forgit commands.

Along with this, I removed the possibility to pass files to rebase.
IMO there is no need to pass files to rebase. I assume this was a copy-paste
error when the rebase function was introduced in the first place.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

There is no need to pass files to rebase. I assume this was a copy-paste
error when the rebase function was introduced in the first place.
Copy link
Owner

@wfxr wfxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sandr01d sandr01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change.

If non-option arguments are passed to `git forgit rebase`, pass them
through directly to `git rebase`, without launching the interactive
selector, just like we do for other forgit commands.
@carlfriedrich carlfriedrich force-pushed the pass-arguments-through-on-rebase branch from 6ca8f77 to c693566 Compare February 15, 2025 13:52
@carlfriedrich carlfriedrich merged commit 09f17c9 into wfxr:main Feb 15, 2025
4 checks passed
@carlfriedrich carlfriedrich deleted the pass-arguments-through-on-rebase branch February 15, 2025 13:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants