Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

What does adoptNode() return for DocumentFragment? #813

Open
TimothyGu opened this issue Dec 31, 2019 · 2 comments
Open

What does adoptNode() return for DocumentFragment? #813

TimothyGu opened this issue Dec 31, 2019 · 2 comments

Comments

@TimothyGu
Copy link
Member

#754 adds to adoptNode():

  1. If node is a DocumentFragment node whose host is non-null, then return.

But adoptNode() must return a Node. What does this "return" mean?

@annevk

@annevk
Copy link
Member

annevk commented Jan 2, 2020

Sigh, it seems that change introduced a bunch of errors. If we can fix the replaceChild() issue somehow I'd say it should return the node passed in, even though it was not adopted.

Perhaps I should first revert that change and test changes though while we figure out a new design. Thoughts welcome.

@TimothyGu
Copy link
Member Author

TimothyGu commented Jan 2, 2020

I think that reverting would be good, especially since none of the major browsers have implemented it. I'd be glad to use jsdom as a testbed for any such change.

TimothyGu added a commit to kontomondo/jsdom that referenced this issue Jan 3, 2020
TimothyGu added a commit to kontomondo/jsdom that referenced this issue Jan 3, 2020
Implementation of whatwg/dom#754 is delayed due to lingering issues with
the PR; see whatwg/dom#813.

Single-page to-upstream tests are updated to declare themselves as such;
per WPT RFC 28
(https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md).

Co-authored-by: Timothy Gu <timothygu99@gmail.com>
domenic pushed a commit to jsdom/jsdom that referenced this issue Jan 4, 2020
Implementation of whatwg/dom#754 is delayed due to lingering issues with
the PR; see whatwg/dom#813.

Single-page to-upstream tests are updated to declare themselves as such;
per WPT RFC 28
(https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md).

Co-authored-by: Timothy Gu <timothygu99@gmail.com>
annevk added a commit that referenced this issue Jan 10, 2020
This reverts commit c825cea. See #813 and #814 for context.
annevk added a commit that referenced this issue Mar 27, 2020
This reverts commit c825cea. See #813 and #814 for context.
annevk added a commit that referenced this issue Mar 27, 2020
Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.
annevk added a commit that referenced this issue Nov 6, 2020
This reverts commit c825cea. See #813 and #814 for context.
annevk added a commit that referenced this issue Nov 6, 2020
Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.
annevk added a commit that referenced this issue Dec 1, 2020
This reverts commit c825cea. See #813 and #814 for context.
annevk added a commit that referenced this issue Dec 1, 2020
Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.
annevk added a commit that referenced this issue Jan 19, 2021
This reverts commit c825cea. See #813 and #814 for context.
annevk added a commit that referenced this issue Jan 19, 2021
Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.
annevk added a commit that referenced this issue Oct 18, 2022
This reverts commit c825cea. See #813 and #814 for context.
annevk added a commit that referenced this issue Oct 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

2 participants