Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

macOS CI fixes #587

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

shinra-electric
Copy link
Contributor

This PR updates the macOS build yaml with the following changes:

  • Update checkout from v2 to v4
  • Update upload-artifact from v2 to v4
  • Removes install step for Python 3.12

Reason for changes: Resolving deprecation warnings

  • v2 of checkout and upload-artifact are deprecated.
  • Python 3.12 is already installed and up to date

Testing:

  • Ensure CI still builds

@shinra-electric
Copy link
Contributor Author

I made the same changes to Qt_Build.yml too, but I didn't update the Windows or Linux jobs because this PR is supposed to be for macOS. They should be updated too.

There is still a deprecation warning for cache@v2 somewhere that needs to be updated, but I haven't found it yet...

@wheremyfoodat wheremyfoodat merged commit 1674ad5 into wheremyfoodat:master Aug 27, 2024
14 checks passed
@shinra-electric shinra-electric deleted the ci-fixes branch August 27, 2024 10:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants