Misc fixes #188
Merged
Misc fixes #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a side effect, this fixes the missing trailing line break.
If you're looking into running uninstalled, you likely don't want to setup as root.
JoeLametta
reviewed
Sep 9, 2017
| @@ -296,13 +296,11 @@ def add_arguments(self): | |||
| self.parser.add_argument('--track-template', | |||
| action="store", dest="track_template", | |||
| default=DEFAULT_TRACK_TEMPLATE, | |||
| help="template for track file naming " | |||
| "(default default)") | |||
| help="template for track file naming") | |||
There was a problem hiding this comment.
Maybe the default value should be kept but in a correct way (not default default).
There was a problem hiding this comment.
It's already displayed.
--track-template TRACK_TEMPLATE
template for track file naming (default default)
(default: %r/%A - %d/%t. %a - %n)
--disc-template DISC_TEMPLATE
template for disc file naming (default default)
(default: %r/%A - %d/%A - %d)
(This is before the patch)
There was a problem hiding this comment.
Great, I suspected I was missing something obvious. Sorry for the useless remark!
JoeLametta
reviewed
Sep 9, 2017
| self.parser.add_argument('--disc-template', | ||
| action="store", dest="disc_template", | ||
| default=DEFAULT_DISC_TEMPLATE, | ||
| help="template for disc file naming " | ||
| "(default default)") | ||
| help="template for disc file naming") |
|
Merged, thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes the output of
whipper cd rip --help(note: the CD-DA check is annoying).The second one was motivated by the missing line break when I got the error.
Third one doesn't need much comment.