Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

restore .flac extension #195

Merged
merged 1 commit into from
Nov 6, 2017
Merged

restore .flac extension #195

merged 1 commit into from
Nov 6, 2017

Conversation

RecursiveForest
Copy link
Contributor

I would appreciate if someone tests the error condition in #194 that this change is fixing before merging, as this is a quick fix on my part.

@Freso
Copy link
Member

Freso commented Sep 20, 2017 •
edited
Loading

With this PR applied the files are now called .flac and I get #196 instead of #194 … (I ripped again using unpatched whipper to verify that #196 is not due to this patch.)

@Freso Freso mentioned this pull request Sep 21, 2017
Closed
@RecursiveForest
Copy link
Contributor Author

@JoeLametta I think this is appropriate to merge given Freso's edited comment above.

@JoeLametta JoeLametta merged commit 1247c94 into whipper-team:master Nov 6, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RecursiveForest @Freso @JoeLametta