Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix recently introduced Python 3 incompatibility #199

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Fix recently introduced Python 3 incompatibility #199

merged 1 commit into from
Oct 8, 2017

Conversation

LingMan
Copy link
Contributor

@LingMan LingMan commented Sep 30, 2017

Fixes d4aad57

@JoeLametta
Copy link
Collaborator

@LingMan Sorry, I don't understand what's the purpose of this PR: even though whipper is going to be ported to Python 3 in the future (#78), right now it only supports Python 2.7. The proposed PR surely isn't enough to make it Python 3 compatible... could you better explain its rationale?

Thanks,
Joe

@LingMan
Copy link
Contributor Author

LingMan commented Oct 8, 2017

You're absolutely right, it doesn't make it Python 3 compatible. I just noticed the breakage while looking at the diff and saw no reason to hold off a fix. Especially considering that all the other prints in that file already use (), which makes this instance easy to miss.

@JoeLametta JoeLametta merged commit f54c4bb into whipper-team:master Oct 8, 2017
@JoeLametta
Copy link
Collaborator

@LingMan Understood.
Merged, thanks.

@LingMan LingMan deleted the patch-1 branch October 8, 2017 20:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants