Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Limit length of filenames #311

Merged
merged 4 commits into from
Oct 22, 2018
Merged

Limit length of filenames #311

merged 4 commits into from
Oct 22, 2018

Conversation

JoeLametta
Copy link
Collaborator

@JoeLametta JoeLametta commented Oct 18, 2018

If whipper generated filenames are longer than the maximum value supported by the filesystem, I/O operations are going to fail.
With this commit filenames which may be too long are truncated to the maximum supported length.

Fixes #197.

@MerlijnWajer
Copy link
Collaborator

Did you test this with unicode?

@MerlijnWajer
Copy link
Collaborator

Other than that, it looks good.

If whipper generated filenames are longer thant the maximum value supported by the filesystem, the I/O operations are going to fail.
With this commit filenames which may be too long are truncated to the maximum allowable length.

Fixes #197.
@JoeLametta JoeLametta force-pushed the limit-fn branch 2 times, most recently from bac4bba to ce212cb Compare October 22, 2018 18:18
@JoeLametta JoeLametta merged commit 02fd962 into master Oct 22, 2018
@JoeLametta JoeLametta deleted the limit-fn branch October 22, 2018 18:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants