Test all four cases of whipper version scheme #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABCbum
force-pushed
the
add-version-test
branch
2 times, most recently
from
c6c2a09 to
c5408c2
Compare
JoeLametta
approved these changes
Jan 28, 2020
JoeLametta
force-pushed
the
add-version-test
branch
from
cbb556d to
544a5d9
Compare
Group different version schemes with the actual one generated from the logger in a list to avoid parsing a whole .log file. The four possible cases are documented here: https://github.com/pypa/setuptools_scm/#default-versioning-scheme. Fixes: whipper-team#427. Signed-off-by: ABCbum <kimlong221002@gmail.com>
JoeLametta
force-pushed
the
add-version-test
branch
from
544a5d9 to
f59caea
Compare
|
Merged, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #427
Solution
Group different version schemes with the actual one generated from the logger
a list to avoid parsing a whole .log file. 4 cases: see https://github.com/pypa/setuptools_scm/#default-versioning-scheme .