Fix cd rip --max-retries option handling #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9db3aa9 introduced the -r/--max-retries option, but passed `'r'` to `argparse.ArgumentParser.add_argument` instead of `'-r'` which causes: Traceback (most recent call last): File "<string>", line 1, in <module> File ".../whipper/command/main.py", line 48, in main cmd = Whipper(sys.argv[1:], os.path.basename(sys.argv[0]), None) File ".../whipper/command/basecommand.py", line 117, in __init__ self.options File ".../whipper/command/basecommand.py", line 117, in __init__ self.options File ".../whipper/command/basecommand.py", line 60, in __init__ self.add_arguments() File ".../whipper/command/cd.py", line 308, in add_arguments default=DEFAULT_MAX_RETRIES) File "/usr/lib/python3.7/argparse.py", line 1354, in add_argument kwargs = self._get_optional_kwargs(*args, **kwargs) File "/usr/lib/python3.7/argparse.py", line 1485, in _get_optional_kwargs raise ValueError(msg % args) ValueError: invalid option string 'r': must start with a character '-' for any arguments passed to `whipper cd rip`. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
|
Merged, thanks for reporting this issue and opening a pull request! |
|
Sure thing. Thanks for reviewing and merging so quickly! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9db3aa9 introduced the -r/--max-retries option, but passed
'r'toargparse.ArgumentParser.add_argumentinstead of'-r'which causes:for any arguments passed to
whipper cd rip. This PR fixes it.Thanks for considering,
Kevin